April 30Apr 30 hi, heads up... I ran into two issues with the Kasa PG3x node server while adding a manually configured Kasa device across subnets/VLANs. My eisy is on 192.168.77.x and the Kasa device is on 192.168.1.x. Routing/firewall access was working, but manual device discovery exposed two plugin-side issues.i was able to local patch, but not sure if these are robust solutions.Device tested: HS103 plug Issue 1:Manual device discovery failed with:Controller.discover_single() got an unexpected keyword argument 'address'In nodes/Controller.py, addmanual_devices() calls:self.discover_single(address=mdev['address'])but discover_single() is defined as:async def discover_single(self, host=None)Changing the call to host= fixed manual discovery. bingo! Issue 2:After discovery worked, the same manual device was repeatedly added as the same node address. The log repeatedly showed:Adding manual device 192.168.1.28Got a DeviceType.Plug: <DeviceType.Plug at 192.168.1.28 - OfficeFront (HS103)>interface:addNode: Adding node OfficeFront(1027f5226cb2)Adding a duplicate guard in add_device_node() to return the existing node from self.nodes_by_mac or self.poly.getNode(cfg['address']) stopped the repeated addNode loop.After those two local patches, the device was discovered and controlled successfully from IoX.I filed separate GitHub issues for the two bugs: https://github.com/UniversalDevicesInc-PG3/udi-poly-kasa/issues/25 https://github.com/UniversalDevicesInc-PG3/udi-poly-kasa/issues/24
Create an account or sign in to comment