Roku TCL Tv's not creating nodes in ISY - special char in name (")

[BillB66]

Guessing the " needs to be escaped.  When I tried to created manually on the ISY with the " in the name gave ISY gave a Bad Request.  I do see the nodes under the  node server.

55" TCL Roku TV - 7125x

2022-10-14 17:38:59,066 MainThread udi_interface ERROR roku:updateNode: Is TV = True
2022-10-14 17:38:59,067 MainThread udi_interface ERROR roku:updateNode: Adding Roku TV node 81739

32" TCL Roku TV - 8116x

2022-10-14 17:39:13,059 MainThread udi_interface      ERROR    roku:updateNode: Is TV = True
2022-10-14 17:39:13,060 MainThread udi_interface      ERROR    roku:updateNode: Adding Roku TV node 30106

All the non TV Rokus did not have an issue (7)

[bpwwer]

It doesn't need to be escaped, it needs to be removed. The quote (") is not a valid character for a node name.

[BillB66]

Sounds good.  Yell when it is fixed and I will update. In the meantime I created the node manually.  Looking at the code, I already see special handling for &, is there a regex of valid chars for node name somewhere?  

https://github.com/BME-node servers/udi-roku-poly/blob/master/nodes/roku.py#L78

 

Also if you are in there, I see a lot of Error spam on application

2022-10-16 12:37:03,818 Thread-311584 udi_interface      ERROR    roku_node:update_status: App id 0 is not mapped to an appliction.
2022-10-16 12:37:03,831 Thread-311579 udi_interface      ERROR    roku_node:update_status: App id 562859 is not mapped to an appliction.

 

Edited October 16, 2022 by BillBinAz