Decided to start the rewrite ; mostly this is modernising the coding of the plugin, but a few features come along for the ride.

Controller:

• re-written to be more pythonic
• Status which is meant to indicate if connected was never working right, on at start, off with stop / delete.  If you monitor, it can be useful.  I use it on folders to switch between my beta, local, and production versions of programs.
• Monitor the control version of ST for heartbeat.
• added NumberofNodes which may be useful to some

Garage

• In the continuing roll out of control, the garage device added it for motor, motion, obstruction.
• sse and event polling re-written, poly persistence, logging much less noisy
• ST is being used to monitor a heartbeat, no status only control.  Just like the controller, can be monitored with program.

Switch

• added TOGGLE, as a receive command, the send will be DON or DOF, let me know how useful
• re-written to be more pythonic, logging should be much less noisy
• persistence is now using the polyglot management instead of individual files
• for those watching, the first run will use the file data then store it with polyglot, then delete the file

Generic / dimmer

• didn't add a TOGGLE but could; thoughts?
• same as switch for re-write, logging, persistence
• much improved behaviour from 3.1.15 for remembering on level, won't get messed up by double off or fast off/on

Temp / TempC / TempRC (curious if anyone uses these still?)

• poly persistence
• re-write, logging
• consolidated into a single file, still configured as separate, for backward compatibility
• variable read / write & updates should work more logically
• variable write happens with shortPoll updates but only when there is a change so not to fire programs constantly

TEST IT OUT & Give me some feedback people!!!

 

VERSION = '3.1.16'
"""
3.1.16
DONE fix controller ST "status" on at start, off at stop / delete, "control" still heartbeat
DONE garage send CMDs, motor, motion, obstruction ; get naming consistent
DONE standardize startup sequence
DONE rewrite checkParams, Discovery
DONE add NumberOfNodes
DONE switch/generic/dimmer/temp(R/C): nodes use polyglot persistence, delete old db files
DONE swtich cmd TOGGLE add
DONE consolidate temp, tempC, tempRC into one module
DONE temp variable writing now with shortPoll (only upon change, considers precision)
DONE refactor function naming
DONE refactor garage, fix persistence, sse client, added heartbeat to ST
TODO backfeed garage improvements to other devices

3.1.15
DONE generic, dimmer, change ST to OL, memory of level for DON, DFON/DFOF, command

3.1.14
DONE commands for switches, generic, dimmer, garage

Edited September 18Sep 18 by sjenkins
garage updates

1.    so I was running the last release (3.1.14) and working fine.

Tested your beta (3.1.16) and I get bad configuration.

** see image for what I had in 3.1.14 that errors in 3.1.16

2. in both 14 and 16 I am getting bad config on garage.  Do the ID have to be 200's?  So lets fix for 16 so I can move forward.   Whats wrong with this

"type": "garage", "name": "VirtualGarage1", "ratgdo": "False"

that also gives bad configuration.

 

THANKS

 

Jeff

@macjeff,

1. the keys, "isy" , "user", "password" has been depreciated for quite a while.  With this re-write I added error checking which defaults to flagging keys which are not recognised.  In the configuration screen under the shortPoll , longPoll entries is a little tick box "Allow ISY access by plugin", make sure to tick that box.
    
2. when you use that kind of configuration you need to enclose the dictionary in {},
   {"type": "garage", "name": "VirtualGarage1", "ratgdo": "False"}
   will work fine for you, no limits on the number (within reason)

hope that helps, & thanks for testing.

 

5 minutes ago, sjenkins said:

@macjeff,

1. the keys, "isy" , "user", "password" has been depreciated for quite a while.  With this re-write I added error checking which defaults to flagging keys which are not recognised.  In the configuration screen under the shortPoll , longPoll entries is a little tick box "Allow ISY access by plugin", make sure to tick that box.
    
2. when you use that kind of configuration you need to enclose the dictionary in {},
   {"type": "garage", "name": "VirtualGarage1", "ratgdo": "False"}
   will work fine for you, no limits on the number (within reason)

hope that helps, & thanks for testing.

 

I assume if I delete those keys, it will just work now without the username and password.   
 

I just wanna make sure I don’t have to enter in new keys for that info

Just now, macjeff said:

I assume if I delete those keys, it will just work now without the username and password.   
 

I just wanna make sure I don’t have to enter in new keys for that info

you assume correct

remember to tick the box by "Allow ISY access by plugin" and save.